chore: use @metamask/messenger CLI for action type generation#577
Closed
cryptodev-2s wants to merge 8 commits intomainfrom
Closed
chore: use @metamask/messenger CLI for action type generation#577cryptodev-2s wants to merge 8 commits intomainfrom
cryptodev-2s wants to merge 8 commits intomainfrom
Conversation
- Delete local scripts/generate-method-action-types.ts (755 lines) - Bump @metamask/messenger from ^0.3.0 to ^1.1.0 - Remove tsx devDependency (no longer needed) - Update generate script to use messenger-generate-action-types CLI
mcmire
reviewed
Apr 1, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
auto-merge was automatically disabled
April 4, 2026 10:00
Pull request was closed
Contributor
Author
|
replaced by #579 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Replace the local
scripts/generate-method-action-types.ts(755 lines) with themessenger-generate-action-typesCLI shipped in@metamask/messenger@^1.1.0.tsxdevDependency (no longer needed)References
Checklist
Note
Medium Risk
Moderate risk because it upgrades
@metamask/messengerto^1.1.0and changes the action-type generation workflow, which could affect build/lint pipelines and generated type compatibility for consumers.Overview
Switches method action-type generation from the repo’s custom
scripts/generate-method-action-types.tsto the upstreammessenger-generate-action-typesCLI, deleting the local script and updating thegenerate-method-action-typespackage script accordingly.Updates dependencies to support this workflow by bumping
@metamask/messengerto^1.1.0and removing thetsxdevDependency (and related lockfile/LavaMoat entries). RegeneratesSmartTransactionsControllermethod action types with the new generator (header comment change only) and documents the messenger bump inCHANGELOG.md.Written by Cursor Bugbot for commit 3b30bff. This will update automatically on new commits. Configure here.